Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add column character sets when show create table #9053

Merged
merged 3 commits into from
Jan 15, 2019
Merged

executor: add column character sets when show create table #9053

merged 3 commits into from
Jan 15, 2019

Conversation

ciscoxll
Copy link
Contributor

@ciscoxll ciscoxll commented Jan 14, 2019 •
edited
Loading

Cherry pick #8866

This change is Reviewable

@ciscoxll
Copy link
Contributor Author

@winkyao @crazycs520 PTAL.

zimulala
zimulala reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2019
winkyao
winkyao reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520
crazycs520 reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@crazycs520 crazycs520 added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2019
@winkyao
Copy link
Contributor

winkyao commented Jan 15, 2019

@ciscoxll tidb-test need to cherry-pick.

@ciscoxll
Copy link
Contributor Author

/run-common-test tidb-test=pr/720

@zz-jason zz-jason merged commit a2787e8 into pingcap:release-2.1 Jan 15, 2019
@ciscoxll ciscoxll deleted the fix_bug_8700 branch January 16, 2019 02:40
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciscoxll @crazycs520 @winkyao @zimulala @zz-jason @sre-bot